-
Notifications
You must be signed in to change notification settings - Fork 302
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
internal/core: fail on missing required only when concrete
In other case it is very much an incomplete error that should be handled accordingly. Also fixes a bug reporting issue where the error for a required field that violates closedness did not get passed to the parent. Fixes #2318 Signed-off-by: Marcel van Lohuizen <mpvl@gmail.com> Change-Id: Id3c629460e137a42fc7fe5dd44f05433c170d848 Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/552185 Unity-Result: CUEcueckoo <cueckoo@cuelang.org> TryBot-Result: CUEcueckoo <cueckoo@cuelang.org> Reviewed-by: Roger Peppe <rogpeppe@gmail.com>
- Loading branch information
Showing
4 changed files
with
25 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
! exec cue vet in.cue | ||
cmp stdout expect-stdout1 | ||
cmp stderr expect-stderr1 | ||
|
||
exec cue vet -c=false in.cue | ||
cmp stdout expect-stdout2 | ||
cmp stderr expect-stderr2 | ||
|
||
-- in.cue -- | ||
x!: string | ||
-- expect-stdout1 -- | ||
-- expect-stderr1 -- | ||
some instances are incomplete; use the -c flag to show errors or suppress this message | ||
-- expect-stdout2 -- | ||
-- expect-stderr2 -- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters