internal/ci: remove hard-codings in gerrithub package

Making these fields parameters simplifies later refactorings.

This results in a single expected change to the trybot_dispatch.yml
workfow file. It makes the use of a linux runner consistent with that
used in other workflows.

Signed-off-by: Paul Jolly <paul@myitcv.io>
Change-Id: I064fc10515f859b6ce9ecbae544e270d9f1ce5b8
Reviewed-on: https://review.gerrithub.io/c/cue-lang/cue/+/551533
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
Unity-Result: CUEcueckoo <cueckoo@cuelang.org>
TryBot-Result: CUEcueckoo <cueckoo@cuelang.org>

.github/workflows/trybot_dispatch.yml

@@ -5,7 +5,7 @@ name: Dispatch trybot
   - repository_dispatch
 jobs:
   trybot:
-    runs-on: ubuntu-20.04
+    runs-on: ubuntu-22.04
     defaults:
       run:
         shell: bash

internal/ci/gerrithub/gerrithub.cue

@@ -39,15 +39,13 @@ import (
 #botGerritHubUser:                   *#botGitHubUser | string
 #botGerritHubUserPasswordSecretsKey: string
 #botGerritHubUserEmail:              *#botGitHubUserEmail | string
+#gerritHubHostname:                  string
+#linuxMachine:                       string
 
 // Pending cuelang.org/issue/1433, hack around defaulting #gerritHubRepository
 // based on #repository
 let _#repositoryURLNoScheme = strings.Split(#repositoryURL, "//")[1]
-#gerritHubRepository: *("https://\(_#gerritHubHostname)/a/" + path.Base(path.Dir(_#repositoryURLNoScheme)) + "/" + path.Base(_#repositoryURLNoScheme)) | _
-
-_#gerritHubHostname: "review.gerrithub.io"
-
-_#linuxMachine: "ubuntu-20.04"
+#gerritHubRepository: *("https://\(#gerritHubHostname)/a/" + path.Base(path.Dir(_#repositoryURLNoScheme)) + "/" + path.Base(_#repositoryURLNoScheme)) | _
 
 #dispatchWorkflow: json.#Workflow & {
 	#type:                  string
@@ -57,7 +55,7 @@ _#linuxMachine: "ubuntu-20.04"
 	jobs: [string]: defaults: run: shell: "bash"
 	jobs: {
 		(#type): {
-			"runs-on": _#linuxMachine
+			"runs-on": #linuxMachine
 			if:        "${{ github.event.client_payload.type == '\(#type)' }}"
 			steps: [
 				#writeNetrcFile,
@@ -98,7 +96,7 @@ _#linuxMachine: "ubuntu-20.04"
 	name: "Write netrc file for cueckoo Gerrithub"
 	run:  """
 			cat <<EOD > ~/.netrc
-			machine \(_#gerritHubHostname)
+			machine \(#gerritHubHostname)
 			login \(#botGerritHubUser)
 			password ${{ secrets.\(#botGerritHubUserPasswordSecretsKey) }}
 			EOD

internal/ci/github/workflows.cue

@@ -63,6 +63,8 @@ _gerrithub: gerrithub & {
 	#botGerritHubUser:                   core.botGitHubUser
 	#botGerritHubUserPasswordSecretsKey: core.botGerritHubUserPasswordSecretsKey
 	#botGerritHubUserEmail:              core.botGitHubUserEmail
+	#gerritHubHostname:                  core.gerritHubHostname
+	#linuxMachine:                       core.linuxMachine
 }
 
 // _base is an instance of ./base, parameterised by the properties of this