Refactor formatter/ANSIColor #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gem is not a dependency of cucumber, but its installation was automatically detected by code. This gem is not very popular, and unmaintained, and is used only to make sure 256 colors are available on the user's terminal. When the gem is not installed, it fallback to defining the 'grey' method anyway. Removing that gem result in declaring the 'grey' method as part of 'Cucumber::Term::ANSIColor': it did not make sense anymore to keep it away from that module which already defined all other term colors.
Putting a call to a regexp before a call to 'Regexp.last_match' may improve the readibility of the code as it follows a more natural reading direction
|
Do we still need the It looks like there were part of old warning mesages which are not displayed anymore: 05252af And they are unused at the moment |
Is this an answer to the question "do we remove those 'cukes' methods"? |
|
Sorry I meant this is the better way to do it (Define method vs eval). |
|
I think we can let those |
|
I know you already approved it |
luke-hill
reviewed
Dec 1, 2021
694fab7 to
86ddc10
Compare
It is supposed to be easier to understand than it was before actually 😓 |
mattwynne
approved these changes
Dec 1, 2021
Co-authored-by: Matt Wynne <matt@cucumber.io>
Co-authored-by: Matt Wynne <matt@cucumber.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1583
Type of change
Checklist:
Your PR is ready for review once the following checklist is
complete. You can also add some checks if you want to.
bundle exec rubocopreports no offenses