Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUnit Platform] Delay plugin creation until test execution #2442

Merged
merged 1 commit into from
Jan 1, 2022

Conversation

mpkorstanje
Copy link
Contributor

Fixes: #2441

@mpkorstanje mpkorstanje force-pushed the junit-platform-delay-plugin-creation branch from dd7548c to 93355e8 Compare January 1, 2022 17:43
@codecov
Copy link

codecov bot commented Jan 1, 2022

Codecov Report

Merging #2442 (2069fb8) into main (71674ca) will increase coverage by 0.08%.
The diff coverage is 100.00%.

❗ Current head 2069fb8 differs from pull request most recent head 80d4cc8. Consider uploading reports for the commit 80d4cc8 to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##               main    #2442      +/-   ##
============================================
+ Coverage     83.67%   83.76%   +0.08%     
- Complexity     2648     2670      +22     
============================================
  Files           317      319       +2     
  Lines          9349     9411      +62     
  Branches        907      910       +3     
============================================
+ Hits           7823     7883      +60     
- Misses         1192     1193       +1     
- Partials        334      335       +1     
Impacted Files Coverage Δ
...latform/engine/CucumberEngineExecutionContext.java 86.66% <100.00%> (+1.30%) ⬆️
.../java/io/cucumber/guice/InjectorSourceFactory.java 96.87% <0.00%> (-3.13%) ⬇️
.../src/main/java/io/cucumber/guice/GuiceBackend.java 100.00% <0.00%> (ø)
...io/cucumber/guice/GuiceBackendProviderService.java 100.00% <0.00%> (ø)
.../src/main/java/io/cucumber/guice/GuiceFactory.java 94.11% <0.00%> (+3.20%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71674ca...80d4cc8. Read the comment docs.

@mpkorstanje mpkorstanje force-pushed the junit-platform-delay-plugin-creation branch 2 times, most recently from ee21b4c to 2069fb8 Compare January 1, 2022 18:12
@mpkorstanje mpkorstanje marked this pull request as ready for review January 1, 2022 18:21
@mpkorstanje mpkorstanje force-pushed the junit-platform-delay-plugin-creation branch from 2069fb8 to 80d4cc8 Compare January 1, 2022 18:23
@mpkorstanje mpkorstanje merged commit f0b5641 into main Jan 1, 2022
@mpkorstanje mpkorstanje deleted the junit-platform-delay-plugin-creation branch January 1, 2022 18:23
@mpkorstanje mpkorstanje added this to the v7.x.x milestone Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Executing Cucumber tests on Junit5 using the JUnit Platform Suite Engine creates empty html or json reports
1 participant