Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate and Remove cucumber.options #1779

Closed
2 tasks done
mpkorstanje opened this issue Sep 22, 2019 · 0 comments
Closed
2 tasks done

Deprecate and Remove cucumber.options #1779

mpkorstanje opened this issue Sep 22, 2019 · 0 comments
Milestone
6.0.0

Comments

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Sep 22, 2019 •
edited
Loading

Currently cucumber.options is used to control cucumbers execution when run through mvn test. This is no longer required with the introduction of property based runtime options in #1741.

Deprecating and eventually removing cucumber.options will allow us to move the CLI argument parsing from io.cucumber.core.options to io.cucumber.core.cli where it belongs.

Additionally

  • We remove --add-plugin and associated logic in RuntimeOptionsBuilder. All plugins are added by default.
  • Separate calling System.exit from parsing the runtime options. Main should check if exit is required after parsing.
  • Write tests that validate if the correct text is written to System.out and System.err by injecting these into CommandlineOptionsParser.

Todo
@mpkorstanje mpkorstanje added the ⚡ enhancement Request for new functionality label Sep 22, 2019
@mpkorstanje mpkorstanje added this to the 5.x.x milestone Sep 22, 2019
@mpkorstanje mpkorstanje removed the ⚡ enhancement Request for new functionality label Oct 4, 2019
@mpkorstanje mpkorstanje mentioned this issue Oct 13, 2019
Closed
mpkorstanje added a commit that referenced this issue Dec 6, 2019
@mpkorstanje
[Core] Deprecate cucumber.options
34352e1 
Currently cucumber.options is used to control cucumbers execution when run
through mvn test. This is no longer required with the introduction of property
based runtime options in #1741.

Part of #1779
@mpkorstanje mpkorstanje changed the title Deprecate cucumber.options Deprecate and Remove cucumber.options Dec 6, 2019
@mpkorstanje mpkorstanje modified the milestones: 5.x.x, 6.0.0 Dec 6, 2019
@mpkorstanje mpkorstanje mentioned this issue Dec 6, 2019
Merged
mpkorstanje added a commit that referenced this issue Dec 6, 2019
@mpkorstanje
[Core] Deprecate cucumber.options
301b445 
Currently cucumber.options is used to control cucumbers execution when run
through mvn test. This is no longer required with the introduction of property
based runtime options in #1741.

Part of #1779
mpkorstanje added a commit that referenced this issue Dec 6, 2019
@mpkorstanje
[Core] Deprecate cucumber.options (#1836)
77021b6 
Currently cucumber.options is used to control cucumbers execution when run
through mvn test. This is no longer required with the introduction of property
based runtime options in #1741.

Part of #1779
mpkorstanje added a commit that referenced this issue Apr 23, 2020
@mpkorstanje
[Core] Remove cucumber.options property (#1958)
839dba7 
`cucumber.options` was used to control cucumbers execution when run through `mvn test`. This is no longer required with the introduction of property based runtime options in #1741. Removing `cucumber.options` allows CLI argument parsing to be separated from property parsing which simplifies the complexity of parsing significantly.

Additionally
 - We remove `--add-plugin` and associated logic in `RuntimeOptionsBuilder`. All plugins are added by default.
 - Separate calling `System.exit` from parsing the runtime options. Main should check if exit is required after parsing.
 - Write tests that validate if the correct text is written to `System.out` and `System.err` by injecting these into `CommandlineOptionsParser`.

Fixes: #1779
@mpkorstanje mpkorstanje mentioned this issue Jan 6, 2023
Closed
mpkorstanje added a commit that referenced this issue Jan 15, 2023
@mpkorstanje
[Core] Warn when cucumber.options is used
e91deac 
In #1779 we deprecated and removed cucumber.options. Unfortunately
there are a slew of outdated tutorials still in existence. And this
outdated knowledge creates a slow trickle of questions on
StackOverflow. It would be nice if we can stop this waste of everyone's
time.

Fixes: #2673
@mpkorstanje mpkorstanje mentioned this issue Jan 15, 2023
Merged
7 tasks
mpkorstanje added a commit that referenced this issue Jan 15, 2023
@mpkorstanje
[Core] Warn when cucumber.options is used
bc2adaf 
In #1779 we deprecated and removed cucumber.options. Unfortunately
there are a slew of outdated tutorials still in existence. And this
outdated knowledge creates a slow trickle of questions on
StackOverflow. It would be nice if we can stop this waste of everyone's
time.

Fixes: #2673
mpkorstanje added a commit that referenced this issue Jan 15, 2023
@mpkorstanje
[Core] Warn when cucumber.options is used
86c2290 
In #1779 we deprecated and removed cucumber.options. Unfortunately
there are a slew of outdated tutorials still in existence. And this
outdated knowledge creates a slow trickle of questions on
StackOverflow. It would be nice if we can stop this waste of everyone's
time.

Fixes: #2673
mpkorstanje added a commit that referenced this issue Jan 15, 2023
@mpkorstanje
[Core] Warn when cucumber.options is used (#2685)
ad47dd5 
In #1779 we deprecated and removed cucumber.options. Unfortunately
there are a slew of outdated tutorials still in existence. And this
outdated knowledge creates a slow trickle of questions on
StackOverflow. It would be nice if we can stop this waste of everyone's
time.

Fixes: #2673
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.0.0
Development

No branches or pull requests
1 participant
@mpkorstanje