Resolve unhandled rejection in BeforeFeatures hook #797 #798
Conversation
|
A linting issue with node version > 4? |
features/hooks.feature
Outdated
| """ | ||
| features/support/hooks.js:2 Something bad | ||
| """ | ||
| And it does not output a valid JSON |
There was a problem hiding this comment.
I think this step (and the related step definition) can just be removed. I don't think we gain much by having it here
There was a problem hiding this comment.
I wanted to make sure the run exits immediately without executing any scenarios.
Is there a more straightforward way to do that?
There was a problem hiding this comment.
I'd rather we use a step like "And it outputs no other text". The way its written now just makes we think we are somehow printing invalid json instead of printing nothing
There was a problem hiding this comment.
Yeah, you're right. I'll push an alternative that makes sure a step output isn't in stdout/stderr.
Remove invalid JSON step Add a shouldFind switch to the output contains text step Change the beforeFeatures hook scenario accordingly
…eforefeatures-rejection
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR resolves #792.
Currently returning a rejected promise from the BeforeFeatures hook will cause the run to: