Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve unhandled rejection in BeforeFeatures hook #797

Closed
wants to merge 69 commits into from
Closed

Resolve unhandled rejection in BeforeFeatures hook #797

wants to merge 69 commits into from

Conversation

yaronassa
Copy link

This PR resolves #792.
Currently returning a rejected promise from the BeforeFeatures hook will cause the run to:

  • Exit with code=0 (expected=1).
  • Throw a node unhandled rejection error.

charlierudolph and others added 30 commits October 13, 2016 13:07
remove tertestrial.yml
bbe5b86
@gforceg @charlierudolph
docs: fix typo (#659)
2a4f968
@Zearin @charlierudolph
docs: update support files api reference (#661)
4660b27
@CodyRay @charlierudolph
Trim paths from @rerun files (#660)
ecca6a2 
Fixes #657. This prevents all the tests from running when there is a trailing
newline in the @rerun file.
catch uncaught errors in the browser
b533408 
resolves #656
2.0 rewrite
735e426
Release 2.0.0-rc.0
97dca94
Release 2.0.0-rc.1
9300508
update dependencies
7a8a6d7
@charlierudolph
stop running features with no scenarios
337a880 
resolves #683
@charlierudolph
update tags documentation
7759312
@charlierudolph
pass attach function to world constructor
ec8e88e 
closes #685
resolves #682
@charlierudolph
docs: update node js example
6db0e81 
closes #688
resolves #668
@charlierudolph
user code runner: clear timeouts
2d3c621 
closes #687
resolves #686
@charlierudolph
json formatter: add isBackground to steps
6e3e282 
closes #689
resolves #663
@charlierudolph
cleanup: remove unneeded wait
0622da0
@charlierudolph
Release 2.0.0-rc.2
b0e1efa
@charlierudolph
fix readme for browser install
02a590a
@aslakhellesoy @charlierudolph
docs: fix tag expression migration guide (#691)
6cb0af9
@charlierudolph
update automatically required files
2d7c252 
closes #693
resolves #690
@charlierudolph
update step definitions docs
cfba574
@charlierudolph
cleanup features
527d2a3
@charlierudolph
prevent crash on empty feature file
6ec67e0 
closes #700
resolves #697
@charlierudolph
validate argument types
bf60b2a 
closes #701
resolves #681
@charlierudolph
make strict the default
4a77c33 
closes #699
resolves #695
@charlierudolph
Release 2.0.0-rc.3
96a61d7
@charlierudolph
update support code interface
fa39a28 
closes #694
resolves #679
@charlierudolph
Release 2.0.0-rc.4
bef2f7e
@floribon @charlierudolph
docs: fix CLI format-options name (#703)
c4868e8
@charlierudolph
dependency manager: switch from npm to yarn
e973f03 
closes #704
charlierudolph and others added 27 commits December 29, 2016 11:16
@charlierudolph
stop transformating generators in node releases
fd78323
@charlierudolph
fix snippet syntax
e3ff263 
closes #711
resolves #710
@charlierudolph
usage and usage-json formatters
5eb8160 
closes #706
resolves #468
Release 2.0.0-rc.6
cb4f94b
@charlierudolph
remove dead link
11d26df
example: update logo
2027cfc
@charlierudolph
demo: fix colors
98b1b1b 
closes #646
@charlierudolph
development: add dependency-lint
7086cd9
@charlierudolph
Update api_reference.md
2580ee2
@temyers @charlierudolph
documentation: fix addTransform parameter name (#738)
09b891b 
resolves #737
@MartinDelille @charlierudolph
docs: normalize syntax highlighting (#726)
e8a785a
@kevgo @charlierudolph
docs: add badge with downloads per month (#722)
54f4a1f
@charlierudolph
fix after hook run order
89b17cb 
closes #744
resolves #743
Release 2.0.0-rc.7
95c6366
@charlierudolph
Update CONTRIBUTING.md
f40b405
@charlierudolph
documentation: fix setWorldConstructor example
998e81d
@aslakhellesoy
upgrade dependency: cucumber-expressions
37a2014 
closes #764
@aslakhellesoy
catch parameter transform errors
f4aae2b 
closes #766
resolves #765
@aslakhellesoy
allow async transforms
e4932f3 
closes #753
@charlierudolph
parameter type: duplicate regex (#780)
201b082
export all formatters
231183a 
closes #781
resolves #769
Release 2.0.0-rc.8
2854439
fix use of gherkin dependency to not rely on removed field
2246394 
closes #788
resolves #787
Release 2.0.0-rc.9
5dbdd10
@charlierudolph
docs: add faq
dfbfed9
@charlierudolph
Update CHANGELOG.md: fix date
714c2e5
Update CHANGELOG.md
9937f9f
@yaronassa yaronassa closed this Mar 23, 2017
@lock
Copy link

lock bot commented Oct 25, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.