Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow single-item arrays as a format #2324

Merged
merged 2 commits into from
Sep 6, 2023
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Sep 6, 2023

🤔 What's changed?

When expressing a format as an array, support a single-item array in the typing.

⚡️ What's your motivation?

If you want to use a formatter for stdout but with a local path containing colons etc, you may want to express that as a single item array to avoid Cucumber seeing the colon(s) and interpreting it as a formatter+target string to be broken apart. See https://github.com/webdriverio/webdriverio/pull/11010/files#r1309127113 for an example in the wild.

This worked anyway at runtime, but the types needed to reflect that, and some tests have been updated to prove it.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant