Skip to content

Commit

Permalink
Merge branch 'main' into add-rerun-order
Browse files Browse the repository at this point in the history
  • Loading branch information
aslakhellesoy authored Jun 29, 2022
2 parents 25513d1 + 4dac0a7 commit cb69d4f
Show file tree
Hide file tree
Showing 9 changed files with 101 additions and 312 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ Please see [CONTRIBUTING.md](https://github.com/cucumber/cucumber/blob/master/CO

## [Unreleased]

## [8.4.0] - 2022-06-29
### Fixed
- Fix issues with using absolute paths for features ([#2063](https://github.com/cucumber/cucumber-js/pull/2063))

## [8.3.1] - 2022-06-21
### Fixed
- Export `IConfiguration` type on API entry point ([#2064](https://github.com/cucumber/cucumber-js/pull/2064))
Expand Down Expand Up @@ -1404,7 +1408,8 @@ this.Given(), this.When(), this.Then() and this.defineStep() ([#2](https://githu

## 0.0.1

[Unreleased]: https://github.com/cucumber/cucumber-js/compare/v8.3.1...HEAD
[Unreleased]: https://github.com/cucumber/cucumber-js/compare/v8.4.0...HEAD
[8.4.0]: https://github.com/cucumber/cucumber-js/compare/v8.3.1...v8.4.0
[8.3.1]: https://github.com/cucumber/cucumber-js/compare/v8.3.0...v8.3.1
[8.3.0]: https://github.com/cucumber/cucumber-js/compare/v8.2.2...v8.3.0
[8.2.2]: https://github.com/cucumber/cucumber-js/compare/v8.2.1...v8.2.2
Expand Down
2 changes: 1 addition & 1 deletion docs/custom_snippet_syntaxes.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
* An object with the following keys:
* `comment`: a comment to be placed at the top of the function
* `functionName`: the function name to use for the snippet
* `generatedExpressions`: from [cucumber-expressions](https://github.com/cucumber/cucumber-expressions-javascript). In most cases will be an array of length 1. But there may be multiple. If multiple, please follow the behavior of the javascript syntax in presenting each of them. See the "multiple patterns" test in this [file](/src/formatter/step_definition_snippet_builder/javascript_snippet_syntax_spec.ts).
* `generatedExpressions`: from [cucumber-expressions](https://github.com/cucumber/cucumber-expressions#readme). In most cases will be an array of length 1. But there may be multiple. If multiple, please follow the behavior of the javascript syntax in presenting each of them. See the "multiple patterns" test in this [file](/src/formatter/step_definition_snippet_builder/javascript_snippet_syntax_spec.ts).
* `stepParameterNames`: names for the doc string or data table parameter when applicable. Theses should be appended to the parameter names of each generated expressions.
* Please add the keywords `cucumber` and `snippets` to your package, so it can easily be found by searching [npm](https://www.npmjs.com/search?q=cucumber+snippets).
* Please open an issue if you would like more information.
2 changes: 1 addition & 1 deletion docs/support_files/step_definitions.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ Cucumber supports two types of expressions:

## Cucumber expressions

[Full docs.](https://cucumber.io/docs/cucumber/cucumber-expressions/)
[Full docs.](https://github.com/cucumber/cucumber-expressions#readme)

Gherkin:
```gherkin
Expand Down
5 changes: 5 additions & 0 deletions features/target_specific_scenarios_by_line.feature
Original file line number Diff line number Diff line change
Expand Up @@ -49,3 +49,8 @@ Feature: Target specific scenarios
| args |
| features/a.feature:2:10 |
| features/a.feature:2 features/a.feature:10 |

Scenario: using absolute paths
When I run cucumber-js with `{{{tmpDir}}}/features/a.feature:2`
Then it fails
And it runs the scenario "first scenario"
89 changes: 2 additions & 87 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"gherkin",
"tests"
],
"version": "8.3.1",
"version": "8.4.0",
"homepage": "https://github.com/cucumber/cucumber-js",
"author": "Julien Biezemans <jb@jbpros.com>",
"contributors": [
Expand Down Expand Up @@ -278,7 +278,6 @@
"mocha": "10.0.0",
"mustache": "4.2.0",
"nyc": "15.1.0",
"portfinder": "1.0.28",
"prettier": "2.6.2",
"reindent-template-literals": "1.1.0",
"shx": "0.3.4",
Expand Down
164 changes: 0 additions & 164 deletions src/formatter/http_stream_spec.ts

This file was deleted.

Loading

0 comments on commit cb69d4f

Please sign in to comment.