[Java] Improve expression creation performance #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improved expression creation performance by about 50%.
Added test case for empty cucumber expression.
mpkorstanje
requested changes
Dec 5, 2022
java/src/main/java/io/cucumber/cucumberexpressions/ExpressionFactory.java
Outdated
Show resolved
Hide resolved
java/src/main/java/io/cucumber/cucumberexpressions/ExpressionFactory.java
Show resolved
Hide resolved
java/src/main/java/io/cucumber/cucumberexpressions/ExpressionFactory.java
Outdated
Show resolved
Hide resolved
java/src/main/java/io/cucumber/cucumberexpressions/ExpressionFactory.java
Outdated
Show resolved
Hide resolved
Refactored code according to PR comments.
mpkorstanje
approved these changes
Dec 5, 2022
I made a benchmark with JMH which shows that the modified method is about 15% faster (see escapeRegex2 below) : Benchmark Mode Cnt Score Error Units CucumberExpressionBenchmark.escapeRegex0 thrpt 25 726563,091 ± 15558,020 ops/s CucumberExpressionBenchmark.escapeRegex1 thrpt 25 782046,026 ± 10993,804 ops/s CucumberExpressionBenchmark.escapeRegex2 thrpt 25 833512,235 ± 25088,968 ops/s The `CucumberExpression` class looks extensively tested, thus I didn't added more test cases. Note: for completeness, I tested another variant (escapeRegex1) which replaces the `ESCAPE_PATTERN.matcher(text).replaceAll(String)` with multiple `String.replace(String,String)` : the performance is not that good (only 8% faster than the original method) and code readability/maintenance is bad. But it was interesting to have the numbers to compare...
|
In order to keep the implementations consistent I think it would be a good idea to port this to the other implementations too. |
|
I added |
|
Well done. I've ran my suite of ~1000 scenarios in dry-run mode and instead of 37s I've got 13s with the latest release. Almost 300% performance boost. |
|
@jkronegg now available in Cucumber 7.10. Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Refactored ExpressionFactory to improve expression creation performance by about 50%.
⚡️ What's your motivation?
Fixes #185
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
The PR has been asked by mpkorstanje
📋 Checklist: