-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Initial support for grouped join pushdown #9032
Open
mcheshkov
wants to merge
26
commits into
master
Choose a base branch
from
initial-grouped-join-pushdown
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,691
−707
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #9032 +/- ##
==========================================
+ Coverage 82.85% 83.13% +0.28%
==========================================
Files 222 225 +3
Lines 78828 80221 +1393
==========================================
+ Hits 65309 66688 +1379
- Misses 13519 13533 +14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
changed the title
feast: Initial support for grouped join pushdown
feat: Initial support for grouped join pushdown
Dec 11, 2024
mcheshkov
force-pushed
the
initial-grouped-join-pushdown
branch
2 times, most recently
from
December 18, 2024 22:18
18417aa
to
739fdc6
Compare
waralexrom
approved these changes
Jan 9, 2025
…s a cube join condition
…mpty_tail) for empty joins in rules
They would be used later as a way to allow replacers to handle column from grouped subquery in join
Non-flatten rules will gain support for joins with grouped-grouped joins SQL generation support in WrappedSelect
mcheshkov
force-pushed
the
initial-grouped-join-pushdown
branch
from
January 13, 2025 13:34
739fdc6
to
fe62c0f
Compare
mcheshkov
force-pushed
the
initial-grouped-join-pushdown
branch
from
January 13, 2025 18:57
fe62c0f
to
9440876
Compare
paveltiunov
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
[Description goes here]