Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(playground): fix version check for yaml model generation #8944

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Nov 12, 2024

This fixes incorrect version checking for yaml data model generation in PG (as v1.0 was treated < 0.31)

This fixes #8943

@KSDaemon KSDaemon requested a review from a team as a code owner November 12, 2024 09:43
Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 9:43am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 9:43am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 9:43am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 9:43am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 9:43am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 9:43am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 9:43am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 12, 2024 9:43am

@KSDaemon KSDaemon merged commit ab8ad2b into master Nov 13, 2024
35 checks passed
@KSDaemon KSDaemon deleted the fix/pg-dm-version-check branch November 13, 2024 19:01
ptiurin pushed a commit to firebolt-db/cube that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect post-v1.0 version check in the data model generation UI
3 participants