Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(schema-compiler): Fix question mark tests #8941

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Conversation

mcheshkov
Copy link
Member

@mcheshkov mcheshkov commented Nov 11, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Description of Changes Made (if issue reference is not provided)

sqlstring uses different question mark sequences for different placehloders: ? for value, ?? for identifier, and skips replacing for ???

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 3:08pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 3:08pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 3:08pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 3:08pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 3:08pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 3:08pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 3:08pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 11, 2024 3:08pm

@mcheshkov mcheshkov changed the title test(schema-compiler): Fix question mark test test(schema-compiler): Fix question mark tests Nov 11, 2024
sqlstring uses different question mark sequences for different placehloders: ? for value, ?? for identifier, and skips replacing for ???
@mcheshkov mcheshkov marked this pull request as ready for review November 11, 2024 16:05
@mcheshkov mcheshkov requested a review from a team as a code owner November 11, 2024 16:05
@mcheshkov mcheshkov merged commit 42861a4 into master Nov 12, 2024
57 checks passed
@mcheshkov mcheshkov deleted the fix-question-tests branch November 12, 2024 15:36
ptiurin pushed a commit to firebolt-db/cube that referenced this pull request Nov 27, 2024
sqlstring uses different question mark sequences for different placehloders: ? for value, ?? for identifier, and skips replacing for ???
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants