Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(schema-compiler): fix Maximum call stack size exceeded if FILTER_PARAMS are used inside dimensions/measures #8867

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix(schema-compiler): fix Maximum call stack size exceeded if FILTER_PARAMS are used inside dimensions/measures #8867

merged 3 commits into from
Nov 13, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Oct 25, 2024 •
edited
Loading

Fixes #8707.

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon requested a review from a team as a code owner October 25, 2024 17:14
@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 6:52pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 6:52pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 6:52pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 6:52pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 6:52pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 6:52pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 6:52pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 8, 2024 6:52pm

@KSDaemon KSDaemon marked this pull request as draft October 25, 2024 20:11
@KSDaemon KSDaemon force-pushed the fix/filter-params-in-dims branch from 8ef597a to 472338e Compare October 28, 2024 16:00
@KSDaemon KSDaemon force-pushed the fix/filter-params-in-dims branch from 472338e to f11d917 Compare November 8, 2024 10:37
@KSDaemon KSDaemon force-pushed the fix/filter-params-in-dims branch from 197dc7c to 1a9b1f4 Compare November 8, 2024 14:27
@KSDaemon KSDaemon marked this pull request as ready for review November 8, 2024 14:32
@KSDaemon KSDaemon merged commit 8e7c5c7 into master Nov 13, 2024
57 checks passed
@KSDaemon KSDaemon deleted the fix/filter-params-in-dims branch November 13, 2024 08:55
KSDaemon added a commit that referenced this pull request Nov 13, 2024
@KSDaemon
fix(schema-compiler): fix Maximum call stack size exceeded if FILTER_…
723de7a 
…PARAMS are used inside dimensions/measures (#8867)

* fix(schema-compiler): fix Maximum call stack size exceeded if FILTER_PARAMS are used inside dimensions/measures

* add tests

* move guard to the filter_params proxy
@KSDaemon KSDaemon mentioned this pull request Nov 13, 2024
Closed
ptiurin pushed a commit to firebolt-db/cube that referenced this pull request Nov 27, 2024
@KSDaemon @ptiurin
fix(schema-compiler): fix Maximum call stack size exceeded if FILTER_…
2b6c9b8 
…PARAMS are used inside dimensions/measures (cube-js#8867)

* fix(schema-compiler): fix Maximum call stack size exceeded if FILTER_PARAMS are used inside dimensions/measures

* add tests

* move guard to the filter_params proxy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paveltiunov paveltiunov paveltiunov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maximum call stack size exceeded
2 participants
@KSDaemon @paveltiunov