ResultSet.normalizePivotConfig() fix #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add parentheses to the condition
igorlukanin
pushed a commit
that referenced
this pull request
Nov 22, 2024
4 tasks
KSDaemon
added a commit
that referenced
this pull request
Jan 9, 2025
* feat(vertica-driver): VerticaDriver * fixed linter error * fix dependencies versions * driver & smoke tests * vertica driver added to integration tests * add vertica to smoke test * update packages * vertica driver published * vertica driver * update README.md * docker installation instruction * up version * update README and package refs * add cube build pipeline * remove * Added Query Implementation (#2) * Added custom dialect for CubeDriver * Sql fixes (#5) * Additional sql fixes (#6) * draft * update test * fix build * update vertica driver dependencies * vertica documentation * add vertica to data sources * fix lint errors * update jest * include vertica tests * update wait strategy and test shared package * change version of vertica driver * some ci-related fixes * fix version, names, refs to align with the Cube repo * update yarn.lock * fix old refs --------- Co-authored-by: Eduard Karacharov <eduard.karacharov@gmail.com> Co-authored-by: timbrownls20 <timbrownls26@hotmail.com> Co-authored-by: Roger <qi.chen@knowitall.net.au> Co-authored-by: David O'Bryen <dj.obryen@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add parentheses to the condition. Without parentheses, it will always create new pivotConfig when timeDimension is present. It makes impossible to pass custom configuration to
pivot()andchartPivot().