chore(ci): Start testing under Node.js 20 (16.x was removed) (#7963)

Node.js 16 is deprecated, starting from 0.35. It's time to remove it from CI, because we don't provide any guaranties for supporting it.
cube-js · Mar 18, 2024 · ee68139 · ee68139
1 parent 6b4a1cf
commit ee68139
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/push.yml b/.github/workflows/push.yml
@@ -44,7 +44,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [16.x, 18.x]
+        node-version: [18.x, 20.x]
       fail-fast: false
 
     steps:

diff --git a/packages/cubejs-api-gateway/test/index.test.ts b/packages/cubejs-api-gateway/test/index.test.ts
@@ -112,8 +112,9 @@ describe('API Gateway', () => {
       .set('Authorization', 'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.e30.t-IDcSemACt8x4iTMCda8Yhe3iZaWbvV5XKSTbuAn0M')
       .expect(400);
 
-    expect(res.body && res.body.error).toStrictEqual(
-      'Unable to decode query param as JSON, error: Unexpected token N in JSON at position 0'
+    expect(res.body && res.body.error).toContain(
+      // different JSON.parse errors between Node.js versions
+      'Unable to decode query param as JSON, error: Unexpected token'
     );
   });