Refactoring WeeklyDebrief

cuappdev · Nov 12, 2023 · 2d6131f · 2d6131f
1 parent 3eba4ef
commit 2d6131f
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 19 deletions.
diff --git a/src/entities/WeeklyDebrief.ts b/src/entities/WeeklyDebrief.ts
@@ -25,10 +25,6 @@ export default class WeeklyDebrief {
   @Property({ default: 0 })
   numShoutouts?: number;
 
-  @Field()
-  @Property({ default: 0 })
-  numBookmarkedArticles?: number;
-
   @Field()
   @Property({ default: 0 })
   numReadArticles?: number;

diff --git a/src/repos/WeeklyDebriefRepo.ts b/src/repos/WeeklyDebriefRepo.ts
@@ -22,7 +22,6 @@ const createWeeklyDebrief = async (
     creationDate,
     expirationDate,
     numShoutouts: user.numShoutouts,
-    numBookmarkedArticles: user.numBookmarkedArticles,
     readArticles: user.readArticles.slice(0, 2),
     readMagazines: user.readMagazines.slice(0, 2),
     numReadArticles: user.readArticles.length,
@@ -36,7 +35,6 @@ const createWeeklyDebrief = async (
         readArticles: [],
         readMagazines: [],
         numShoutouts: 0,
-        numBookmarkedArticles: 0,
         weeklyDebrief,
       },
     },

diff --git a/src/tests/user.test.ts b/src/tests/user.test.ts
@@ -169,19 +169,6 @@ describe('weekly debrief tests:', () => {
     expect(getUsersResponse.numShoutouts).toEqual(1);
   });
 
-  test('incrementBookmarks - 1 user, 1 shoutout', async () => {
-    const users = await UserFactory.create(1);
-    const insertOutput = await UserModel.insertMany(users);
-    await UserRepo.incrementBookmarks(insertOutput[0].uuid);
-
-    // update database
-    const pub = await PublicationFactory.getRandomPublication();
-    await UserRepo.followPublication(users[0].uuid, pub.slug);
-
-    const getUsersResponse = await UserRepo.getUserByUUID(insertOutput[0].uuid);
-    expect(getUsersResponse.numBookmarkedArticles).toEqual(1);
-  });
-
   test('appendReadFlyer', async () => {
     const users = await UserFactory.create(1);
     const flyers = await FlyerFactory.create(1);