Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: e2e tests and context for event handling in cluster-scoped resources #3

Merged
merged 2 commits into from
Mar 23, 2023
Merged

fix: e2e tests and context for event handling in cluster-scoped resources #3

merged 2 commits into from
Mar 23, 2023

Conversation

eshaanm25
Copy link

What this PR does / why we need it:

  • Fixes e2e tests that were failing (1, 2, 3, 4, 5, 6) by correcting the namespace that the test was looking for events in.
  • Add a note in the READMEs, flag descriptions, and docs indicating that cluster scoped resources would create events in the GK namespace (based on the following suggestion)

@eshaanm25
fix: added namespaces in e2e events test
6513e4e 
Signed-off-by: Eshaan Mathur <37758843+eshaanm25@users.noreply.github.com>
@eshaanm25
docs: added context for event handling in cluster-scoped resources
64e5d66 
Signed-off-by: Eshaan Mathur <37758843+eshaanm25@users.noreply.github.com>
@ctrought ctrought merged commit 3a9d402 into ctrought:fix-emit-events-namespace Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eshaanm25 @ctrought