Save and handle post login redirect #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That was a really weird rebase O.o Worked well after squashing, but before that, it was really messy for some reason |
4dd25a2 to
22fa180
Compare
ctron
reviewed
Jan 26, 2024
| @@ -33,7 +33,7 @@ web-sys = { version = "0.3", features = [ | |||
| ] } | |||
|
|
|||
| openidconnect = { version = "3.0", optional = true } | |||
| yew-nested-router = { version = ">=0.5, <0.7", optional = true } | |||
| yew-nested-router = { version = ">=0.6.3, <0.7", optional = true } | |||
There was a problem hiding this comment.
I guess it's time to bring this back to just 0.6.3. But I can do this post-merge.
ctron
approved these changes
Jan 26, 2024
| self | ||
| } | ||
|
|
||
| /// Use `yew-nested-route` history api for post-login redirect callback |
| @@ -362,6 +393,24 @@ where | |||
| } | |||
| } | |||
|
|
|||
| fn post_login_redirect(&self) -> Result<(), OAuth2Error> { | |||
| let config = self.config.as_ref().ok_or(OAuth2Error::NotInitialized)?; | |||
| let Some(redirect_callback) = config | |||
There was a problem hiding this comment.
If didn't know about let-else so far. Cool!
There was a problem hiding this comment.
It's new-ish and super convenient for return early pattern :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
squashed commits from #25 and rebased on main
obsoletes #25 #28