Fixed repodata creation for multiple rpms #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Big thanks! Let me know when I should make a new release of the plugin. |
|
Thanks for responding so fast :) It would be really cool to release a new version right away. |
|
The release is done. It may take a while into it is synced with Maven central. Many thanks for the PR! |
|
@triggetry Do you have a Twitter handle for mentioning you? |
|
That was easy 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The creation of repodata files was broken when more than one rpm were added to the yum repository. More specifically, the resulting metadata
*.xmlfiles have been overwritten in each loop iteration, resulting in having only one package defined in the repodata files. Thus, theyum-repositorygoal was not usable when intending to add more than one rpm to the repository.This PR fixes #12 by making sure that the
contextvariable to add rpm packages gets reused in each loop iteration instead of recreated.