Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPM Package Name in Unnecessary Lowercase #6

Closed
Korimsoft opened this issue Jan 17, 2017 · 6 comments
Closed

RPM Package Name in Unnecessary Lowercase #6

Korimsoft opened this issue Jan 17, 2017 · 6 comments

Comments

@Korimsoft
Copy link

Hello, when we are using your plugin, we would like to have the RPMs case-sensitive. However, current names are created with toLowerCase() in RpmMojo.java, line 711 (makePackageName).

We modified it to

private String makePackageName ()
    {
        return this.packageName.trim();
    }

and it works like a charm.

@ctron
Copy link
Owner

ctron commented Jan 29, 2017

The recommendation for RPM is to go all lowercase.

But you are right, technically you could use uppercase as well. I would suggest to add a new parameter which allows to disable the enforcing of lowercase. Leaving the default to stick with the current behavior.

@Korimsoft
Copy link
Author

I know, however our product management wants to have some obscure naming pattern that defies the whole RPM package naming convention (and they are immune to rational arguments).
We are planning with my colleague to implement a custom pattern parameter if we have some spare time. The default behavior will be as usual but the user will have choice to "mutilate" the package name to their needs.

@ctron
Copy link
Owner

ctron commented Apr 10, 2017

I will try to make a new version this week with a new Package Drone base. Fixing this issue as well.

I am not 100% sure how to do it. As this might break stuff for people which currently depend on this.

But I would still think breaking the old behavior would make sense. So I would suggest to create a new option set <naming> which can have sub-elements. One of them (the first) being <case> which can be set to lowercase, unmodified, …

If the name contains uppercase characters now and the naming option set is missing, then a warning is printed out which tries to explain the breaking change.

ctron added a commit that referenced this issue Apr 12, 2017
ctron added a commit that referenced this issue Apr 12, 2017
@ctron
Copy link
Owner

ctron commented Apr 12, 2017

I pushed a change which should fix this.

Is there a chance you can test this from a SNAPSHOT version of the plugin?

@Korimsoft
Copy link
Author

Hi, unfortunately, I am leaving the company due to 'political' reasons, so probably I won't be able to test the option soon enough (I would have to set up a dev-env on my personal computer). Anyway, thank you very much for your time. I hope I will be able to make such contributions soon as well.

@ctron
Copy link
Owner

ctron commented Apr 13, 2017

I just released version 0.9.0 which fixes this!

@ctron ctron closed this as completed Apr 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants