TEST: PR test for builds on merge requests #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THIS IS BREAKING AND NOT INTENDED TO BE SHIPPED
Since we need to make sure all our checks run BEFORE the commit is pushed to a branch we're swithcing this to `on pull_request_target` to enable external contibutors.
|
This did not do what I expected |
Since we need to make sure all our checks run BEFORE the commit is pushed to a branch we're swithcing this to `on pull_request_target` to enable external contibutors.
Testing resubmission fix
trying to move from: merge_commit_sha to HEAD
This reverts commit 27c6f41.
This reverts commit 45e010a.
This reverts commit 30feb89.
Since we need to make sure external contributors code actually compiles prior to merging. To get access to the forked repos merge request we need to switch over our push/pull_request to pull_request_target. In addition we're fixing up some Naming Conventions, adding aarch64 to this branch and fixing the naming so that we can quickly identify if the CI is for x86_64 or aarch64.
5193112 to
3b12161
Compare
105bc2d to
ebe2551
Compare
5a2bd5b to
d38c5b9
Compare
|
Closing for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.