-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
data.table::fread
#2
Comments
The ideal solution is also use
Right now the parameter method is simplest without need of much change to existing code. We can further improve this depend on new usage or development in related packages. |
I think the most important thing is that as.telemetry "just work" with default arguments. I put in some code that checks to see if the filename looks like a CSV, then attempts fread. If the filename doesn't look like a CSV or fread fails, then the slower read.table is used instead.
We could add in more logic for different compression formats, but I don't know that the command & pipe notation is the same across platforms. |
@chfleming This is a much better solution compared to extra parameter. I think there is no need to check compression formats since there are many possibilities and platform compatibility problems. |
@chfleming I think we can actually just
I think the direct read test should be fast enough that comparable to the file name check, and it will handle all possible cases without complex logic. |
That seems to work well. Pushed. |
zipfile = FALSE
forfread
, fall back toread.csv
when zip file is needed.For 160M csv,
fread
took 2.64s whileread.csv
took 21s.The text was updated successfully, but these errors were encountered: