Fix resolving logLevel variable in casskop chart #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michal Zylowski <michal.zylowski@dynatrace.com>
cscetbon
approved these changes
Oct 15, 2024
|
It looks like the tests failed or something that is out of the scope of my change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
PR fixes the problem with passing value from values.yaml instead of pushing direct string
.Values.logLevelto environment variable.Why?
I just found an obvious issue with passing logLevel variable via values.yaml during the update of casskop to latest 2.2.6 release. See the screen:
(This is a diff of the changes that I observe during pushing new chart to k8s)
Additional context
Checklist
To Do
@AKamyshnikova @cscetbon any chances to merge this change quickly so I'll be able to fix my cluster without patching the chart locally?