Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debug print patch when statefulset is going to be updated #111

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

pchmieli
Copy link

@pchmieli pchmieli commented Jun 5, 2023

Q A
New feature? [x]
License Apache 2.0

What's in this PR?

Printing statefulset patch when it is going to be updated.

Why?

Current method (pretty.Compare(sts1.Spec, sts2.Spec)) is too verbose for most use cases.

  • it shows whole object and mark changes
  • it marks unrelated changes like kubernetes defaults, e.g.
  • RevisionHistoryLimit: 10,
  • RevisionHistoryLimit: nil,

New method is added besides the old one.

Checklist

  • Implementation tested

@AKamyshnikova AKamyshnikova merged commit 0f7d712 into cscetbon:master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants