Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: enforce changelog #965

Merged
merged 15 commits into from
Jul 13, 2020
Merged

CI: enforce changelog #965

merged 15 commits into from
Jul 13, 2020

Conversation

ishank011
Copy link
Contributor

@ishank011 ishank011 commented Jul 10, 2020

With this PR, when adding a feature or fixing a bug, a changelog needs to be specified, failing which the build wouldn't pass. Also configured the update-docs bot to comment if no changelog is created.

Without changelog: https://cloud.drone.io/cs3org/reva/1858/1/5
With changelog: https://cloud.drone.io/cs3org/reva/1859/1/5

@ishank011 ishank011 requested a review from labkode as a code owner July 10, 2020 15:16
@ishank011 ishank011 marked this pull request as draft July 10, 2020 15:24
@ishank011 ishank011 marked this pull request as ready for review July 10, 2020 16:41
@labkode
Copy link
Member

labkode commented Jul 13, 2020

@ishank011 nice job!

@labkode labkode merged commit 3897ec3 into cs3org:master Jul 13, 2020
@ishank011 ishank011 deleted the changelog branch July 13, 2020 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants