Properly read permissions when creating public link #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a bug where the permKey variable is redefined inside a block due to the extra colon, so the value did not get set to the outer variable which got stuck on the value 1.
labkode
approved these changes
Jun 18, 2020
|
nice catch :D. Scopes are a !&@# |
C0rby
pushed a commit
to owncloud/reva
that referenced
this pull request
Jun 30, 2020
There was a bug where the permKey variable is redefined inside a block due to the extra colon, so the value did not get set to the outer variable which got stuck on the value 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a bug where the permKey variable is redefined inside a block
due to the extra colon, so the value did not get set to the outer
variable which got stuck on the value 1.
@refs FYI