Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public Links Download / Upload #822

Closed
wants to merge 15 commits into from
Closed

Public Links Download / Upload #822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
9299d27
first working draft
refs Jun 10, 2020
547c29b
inline return
refs Jun 10, 2020
5c268da
working upload
refs Jun 16, 2020
3ebcbaa
spare a few allocations
refs Jun 16, 2020
69cd5a0
Merge branch 'master' into public-links-download
refs Jun 16, 2020
d37c4c6
update branch
refs Jun 18, 2020
8028f3f
provide missing parameter on InitiateUpload
refs Jun 18, 2020
e8362d8
single file publicly shared download working
refs Jun 18, 2020
575b62b
filename on single shared file
refs Jun 18, 2020
3b6f6d5
apply @PVince81 patch
refs Jun 18, 2020
625e459
take into account depth
refs Jun 19, 2020
1f7f453
improve base logic
refs Jun 19, 2020
52366d0
Merge branch 'master' into public-links-download
refs Jun 19, 2020
5d692d2
resolve append not assigned to same destination variable
refs Jun 19, 2020
707fbe9
disable gocritic for long ifElse chains
refs Jun 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .golangci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ issues:
text: "SA1019:"
linters:
- staticcheck
- path: internal/http/services/owncloud/ocdav/propfind.go
text: "ifElseChain:"
linters:
- gocritic
linters:
enable:
- bodyclose
Expand Down
1 change: 0 additions & 1 deletion internal/grpc/services/gateway/publicshareprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,6 @@ func (s *svc) GetPublicShareByToken(ctx context.Context, req *link.GetPublicShar
return nil, err
}

// TODO the double call is not here
res, err := driver.GetPublicShareByToken(ctx, req)
if err != nil {
return nil, err
Expand Down
1 change: 0 additions & 1 deletion internal/grpc/services/gateway/storageprovider.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -828,7 +828,6 @@ func (s *svc) UnsetArbitraryMetadata(ctx context.Context, req *provider.UnsetArb
}

func (s *svc) stat(ctx context.Context, req *provider.StatRequest) (*provider.StatResponse, error) {
// TODO(refs) do we need to append home to every stat request?
c, err := s.find(ctx, req.Ref)
if err != nil {
if _, ok := err.(errtypes.IsNotFound); ok {
Expand Down
Loading