Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not try to initialize notification helper if settings are not there #3969

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

javfg
Copy link
Contributor

@javfg javfg commented Jun 13, 2023

This should prevent the errors seen here, which should just be an Info level message about notifications not configured.

Also removes some typos and unneeded stuff from the sql script.

@update-docs
Copy link

update-docs bot commented Jun 13, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@javfg javfg changed the title Do not tryt to initialize notification helper if settings are not there Do not try to initialize notification helper if settings are not there Jun 13, 2023
@javfg javfg force-pushed the notifications-skipinit branch from abf8859 to b8284d8 Compare June 13, 2023 09:48
@javfg javfg requested a review from a team as a code owner June 13, 2023 09:48
@gmgigi96 gmgigi96 merged commit 43b4669 into cs3org:master Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants