Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dataproviders now return file metadata #3154

Merged
merged 9 commits into from
Aug 18, 2022
Merged

dataproviders now return file metadata #3154

merged 9 commits into from
Aug 18, 2022

Conversation

butonic
Copy link
Contributor

@butonic butonic commented Aug 16, 2022 •
edited
Loading

Dataprovider drivers can now return file metadata. When the resource info contains a file id, the mtime or an etag, these will be included in the response as the corresponding http headers.

This saves an internal stat after handling webdav put requests, preventing a race condition and contributes to #2976

@butonic
dataproviders now return file metadata
7a4abba 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic requested review from labkode, ishank011, glpatcern and a team as code owners August 16, 2022 09:41
@butonic butonic self-assigned this Aug 16, 2022
butonic added 4 commits August 16, 2022 10:45
@butonic
actually pass metadata
1aafd7a 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
drop comment
8b89a21 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
make eosfs return resourceinfo on upload
532cca9 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
refactor MTimeToTS()
26089ed 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic marked this pull request as draft August 16, 2022 14:42
butonic added 3 commits August 16, 2022 14:43
@butonic
make owncloudsql return resourceinfo on upload
185ae5e 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
make localfs return resourceinfo on upload
f080f22 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic
make s3 fs return resourceinfo on upload
7a73c0d 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic force-pushed the return-metadata-in-put-response-headers branch 3 times, most recently from f8bb52f to 81fca6f Compare August 18, 2022 13:24
@butonic
make nextcloud driver return resourceinfo on upload
81fca6f 
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
@butonic butonic marked this pull request as ready for review August 18, 2022 13:49
dragonchaser
dragonchaser approved these changes Aug 18, 2022
View reviewed changes
Copy link

@dragonchaser dragonchaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@butonic butonic merged commit 9c40953 into cs3org:edge Aug 18, 2022
@butonic butonic deleted the return-metadata-in-put-response-headers branch August 18, 2022 14:59
@kobergj kobergj mentioned this pull request Oct 14, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 20, 2022
Merged
@kiranparajuli589 kiranparajuli589 mentioned this pull request Oct 28, 2022
Merged
@kobergj kobergj mentioned this pull request Dec 19, 2022
Merged
@kobergj kobergj mentioned this pull request May 22, 2023
Closed
@kobergj kobergj mentioned this pull request Mar 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dragonchaser dragonchaser dragonchaser approved these changes

@labkode labkode Awaiting requested review from labkode labkode is a code owner

@ishank011 ishank011 Awaiting requested review from ishank011

@glpatcern glpatcern Awaiting requested review from glpatcern glpatcern is a code owner

Assignees

@butonic butonic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@butonic @dragonchaser