-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Populate share jail #2884
Merged
Merged
Populate share jail #2884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
butonic
requested review from
labkode,
ishank011,
wkloucek,
glpatcern and
a team
as code owners
May 19, 2022 14:10
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
butonic
force-pushed
the
populate-share-jail
branch
from
May 19, 2022 14:12
07e8d8e
to
0e31ac2
Compare
kobergj
requested changes
May 19, 2022
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
internal/grpc/services/sharesstorageprovider/sharesstorageprovider.go
Outdated
Show resolved
Hide resolved
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> populate share jail Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
butonic
force-pushed
the
populate-share-jail
branch
from
May 19, 2022 14:30
0e31ac2
to
cee3342
Compare
Co-authored-by: kobergj <juliankoberg@googlemail.com>
Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
Kudos, SonarCloud Quality Gate passed! |
kobergj
approved these changes
May 19, 2022
This was referenced May 20, 2022
25 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The virtual share jail now shows the mounted shares to allow the desktop client to sync that collection.
see owncloud/ocis#3719