don't include versions in quota check #2863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
977ce4e to
372bfe7
Compare
dragotin
approved these changes
May 13, 2022
| if quotaByte == "" { | ||
| // if quota is not set, it means unlimited | ||
| return true, nil | ||
| } | ||
| total, _ = strconv.ParseUint(quotaByte, 10, 64) | ||
| total, _ := strconv.ParseUint(quotaByte, 10, 64) |
There was a problem hiding this comment.
When reading the code, I found total a bit of a missleading name. Maybe change to quotaByte and the String of quotaByte to quotaByteStr ?
|
Kudos, SonarCloud Quality Gate passed!
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the quota check to not count the quota of previous versions.
This will fix the situation where the quota is exceeded and the user wants to create a new version of an existing file.
See this issue for more information: owncloud/ocis#2829