Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move user context methods into separate package #1982

Merged
merged 5 commits into from
Aug 11, 2021
Merged

Move user context methods into separate package #1982

merged 5 commits into from
Aug 11, 2021

Conversation

jimil749
Copy link
Contributor

This PR moves the user-context methods out of the user pkg into a separate userctx package.

Signed-off-by: Jimil Desai jimildesai42@gmail.com

@jimil749 jimil749 requested a review from labkode as a code owner August 10, 2021 09:29
@update-docs
Copy link

update-docs bot commented Aug 10, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@jimil749 jimil749 mentioned this pull request Aug 10, 2021
Closed
@jimil749 jimil749 requested a review from ishank011 August 10, 2021 10:06
ishank011
ishank011 reviewed Aug 10, 2021
View reviewed changes
Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the token methods to this pkg as well? Maybe we'll have to rename it

@jimil749
Copy link
Contributor Author

@ishank011 sorry for the late turnaround, VSCode gave me a lot of trouble this afternoon!

@jimil749
Copy link
Contributor Author

I see that the tests are failing. Will take a look

@jimil749
chore: move user context methods into separate package
b90aa1b 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
add changelog and license
76a7085 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
move tokenctx methods to ctx package
8dd72f5 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
update ctx in eosfs_test
ea45e3d 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@jimil749
fix: add tokenKey in same block as userKey
7af051e 
Signed-off-by: Jimil Desai <jimildesai42@gmail.com>
@ishank011 ishank011 merged commit 8485d40 into cs3org:master Aug 11, 2021
@jimil749 jimil749 deleted the user-ctx branch August 11, 2021 15:15
@butonic butonic mentioned this pull request Aug 11, 2021
Merged
@pascalwengerter pascalwengerter mentioned this pull request Aug 24, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishank011 ishank011 ishank011 approved these changes

@labkode labkode Awaiting requested review from labkode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimil749 @ishank011