Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix TUS uploads with transfer token only #1941

Merged
merged 1 commit into from
Dec 2, 2021
Merged

fix TUS uploads with transfer token only #1941

merged 1 commit into from
Dec 2, 2021

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Jul 30, 2021

TUS uploads had been stopped when the user JWT token expired, even if only the transfer token should be validated. Now uploads will continue as intended.

fixes owncloud/ocis#1205

@update-docs
Copy link

update-docs bot commented Jul 30, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek changed the title fix tus with transfer token only fix TUS uploads with transfer token only Aug 5, 2021
@wkloucek wkloucek marked this pull request as ready for review August 5, 2021 09:17
@wkloucek wkloucek requested a review from labkode as a code owner August 5, 2021 09:17
@wkloucek wkloucek requested a review from ishank011 August 5, 2021 09:17
@wkloucek
Copy link
Contributor Author

@ishank011 I don't know how to get Codacy green again, because I already renamed the file

cmd/reva/upload.go Outdated Show resolved Hide resolved
@butonic
Copy link
Contributor

butonic commented Oct 8, 2021

This is related to the app provider scope checks @ishank011 can we merge this? cc @wkloucek @C0rby

@wkloucek wkloucek self-assigned this Nov 10, 2021
@labkode labkode self-requested a review December 2, 2021 11:27
@labkode labkode merged commit 046c3d5 into cs3org:master Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Single big file upload with desktop-client fails if OIDC token expires
4 participants