Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-only] Add atomicity docs for decomposedfs operations #1645

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

aduffeck
Copy link
Contributor

This pr adds a document describing the atomicity of the writing decomposedfs operations.

@aduffeck aduffeck requested a review from labkode as a code owner April 19, 2021 09:28
@update-docs
Copy link

update-docs bot commented Apr 19, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @aduffeck this looks good! Would it make more sense to add this to https://github.com/cs3org/reva/tree/master/docs/content/en/docs/config/packages/storage/fs? That way it would be present in the config docs as well (similar to https://reva.link/docs/config/http/services/mentix/)


### Negative Effects

Failing calls will leave an orphened node behind (See reva issue [#1601](https://github.com/cs3org/reva/issues/1601)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo

@aduffeck
Copy link
Contributor Author

@ishank011 I fixed the typo and moved the docs as suggested.

Copy link
Contributor

@ishank011 ishank011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishank011 ishank011 merged commit 6fc0227 into cs3org:master Apr 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants