-
Notifications
You must be signed in to change notification settings - Fork 113
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Use field mask to update received shares
The next step for the shares storahge provider is to introduce field masks so the shares can update state and mount point. This PR is based on the full changeset, but removes everything but the API change. Add a sharesstorageprovider The provider exposes all received shares. It can be mounted to /home/Shares to make a lot of special cases for shares handling in the gateway and storage drivers superfluous. Add missing mock file Implement methods for setting/unsetting arbitrary metadata Fix tests Adapt to changes from rebase Fix creating references with embedded mounts Fix corner cases when stating shares Allow moves between shares on the same storage Make the storage rules known to the gateway as well Do not choke on non-existent shares Reject a share when it is being deleted Fix rebase artifacts WIP: Refactor statting shares. Merge shares permissions. update after rebase, fix tests Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> list all shares Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> work on api change Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> Fix build Persist mountpoints in the share managers followin the new cs3 api Add support for renaming shares in the SharesStorageprovider Adapt commands for updating received shares Regenerate the share manager mock Fix linter warning Do not raise an internal error when trying to access non-existent shares Make hound happy Fix wrong column name in query Fix typo Do not confuse user and group names Add test for listing received group shares Do not list parent group shares if there is a child share for it already Make hound happy Hide the fact that accepted groups shares can be child shares in the db list shares using the shares manager + hide group shares when the same resource has a user and group share refactor all the ocs error writing from the new code Only collide with mountpoints of shares pointing do different resources Also return shares being shared with one of the user's groups Add sharesstorageprovider service file for local acceptance tests Adapt nextcloud share manager to new method signature Also remove the test for UpdateReceivedShare which can not be tested anymore with the new signature. The ReceivedShare never held the display name that's being tested so the test only passed on the data from the update field, but since the method only takes the actual received share now this is no longer possible. WIP: use go-cs3apis fork until it has been merged Add placeholder changelog to make CI run Tweak documentation on how to run the acceptance tests Add missing storage registry rule for the sharesstorageprovider Fix revad config for local acceptance tests reduce changes to share api change Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de> JSON encode the FieldMask parameter as-is paramsObj.Ref -> paramsObj.ReceivedShare Restore deleted test update code comment remove go mod replace Signed-off-by: Jörn Friedrich Dreyer <jfd@butonic.de>
- Loading branch information
Showing
26 changed files
with
560 additions
and
174 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
Change: Sharemanager API change | ||
|
||
This PR updates reva to reflect the share manager CS3 API changes. | ||
|
||
https://github.com/cs3org/reva/pull/2121 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.