Merge pull request #3918 from kobergj/ReturnCorrectStatusCode

Fix StatusCode
cs3org · May 25, 2023 · 9334e21 · 9334e21
2 parents d3e496e + 64f86b7
commit 9334e21
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/changelog/unreleased/dont-enumerate-user.md b/changelog/unreleased/dont-enumerate-user.md
@@ -2,4 +2,5 @@ Bugfix: Dont enumerate users
 
 Fixes a user enumeration via DELETE share endpoint
 
+https://github.com/cs3org/reva/pull/3918
 https://github.com/cs3org/reva/pull/3916
diff --git a/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go b/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/shares.go
@@ -688,7 +688,7 @@ func (h *Handler) UpdateShare(w http.ResponseWriter, r *http.Request) {
 		h.updateShare(w, r, share) // TODO PUT is used with incomplete data to update a share}
 		return
 	}
-	response.WriteOCSError(w, r, response.MetaPathNotFound.StatusCode, "cannot find share", nil)
+	response.WriteOCSError(w, r, response.MetaNotFound.StatusCode, "cannot find share", nil)
 }
 
 func (h *Handler) updateShare(w http.ResponseWriter, r *http.Request, share *collaboration.Share) {
@@ -814,7 +814,7 @@ func (h *Handler) RemoveShare(w http.ResponseWriter, r *http.Request) {
 		h.removeSpaceMember(w, r, shareID, prov)
 		return
 	}
-	response.WriteOCSError(w, r, response.MetaPathNotFound.StatusCode, "cannot find share", nil)
+	response.WriteOCSError(w, r, response.MetaNotFound.StatusCode, "cannot find share", nil)
 }
 
 // ListShares handles GET requests on /apps/files_sharing/api/v1/shares
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2,4 +2,5 @@ Bugfix: Dont enumerate users

		Fixes a user enumeration via DELETE share endpoint

		https://github.com/cs3org/reva/pull/3918
		https://github.com/cs3org/reva/pull/3916