Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extensions for the AppProviders to improve the UI #145

Merged
merged 5 commits into from
Sep 22, 2021

Conversation

glpatcern
Copy link
Member

@glpatcern glpatcern commented Sep 10, 2021

This PR introduces further extensions for the open-in-app workflow:

  • AppProviders expose a capability to identify fully fledged editors vs viewers
  • Mime types are defined including a friendly name and a corresponding file extension

This allows the UI to e.g. populate a New menu with all types for which an editor AppProvider is defined.

The extensions constitute breaking changes for the protobuf bindings, and can be merged once cs3org/reva#2067 is ready to be merged.

@glpatcern glpatcern requested a review from labkode as a code owner September 10, 2021 11:55
@glpatcern glpatcern self-assigned this Sep 10, 2021
@glpatcern glpatcern marked this pull request as draft September 10, 2021 11:56
@glpatcern glpatcern requested a review from wkloucek September 10, 2021 11:56
Copy link
Member

@labkode labkode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. In general is better to not break backwards compatibility by maintaining the order of the fields in the protobuf definitions. However as this PR introduces a new REQUIRED fields it does not change anything.

@wkloucek please review and approve.

@glpatcern
Copy link
Member Author

glpatcern commented Sep 13, 2021

Yeah I thought about that and also about leaving them OPTIONAL (the capability at least could default to VIEWER) but in the end we need them...

glpatcern added a commit to glpatcern/reva that referenced this pull request Sep 13, 2021
glpatcern added a commit to glpatcern/reva that referenced this pull request Sep 13, 2021
glpatcern added a commit to glpatcern/reva that referenced this pull request Sep 13, 2021
@glpatcern
Copy link
Member Author

glpatcern commented Sep 14, 2021

Self-reviewing:

This model is still missing the ability to register the mime type attributes (name, ext, icon...) from "outside". A SetMimeType RPC method may be needed for this, but for now the implementation in Reva will populate these metadata from the config, without further needs in terms of CS3APIs.

Also, I don't understand why such a large diff in proto.lock. I dropped and recreated it as this is a breaking change, does that mean that we were carrying over lots of "garbage"?

@glpatcern glpatcern force-pushed the main branch 3 times, most recently from 192c90b to b156daf Compare September 17, 2021 12:37
@glpatcern glpatcern marked this pull request as ready for review September 17, 2021 12:55
@glpatcern glpatcern requested a review from labkode September 17, 2021 12:58
Makefile Show resolved Hide resolved
@glpatcern glpatcern force-pushed the main branch 3 times, most recently from f381ff8 to f7ab578 Compare September 20, 2021 09:57
@ishank011
Copy link
Contributor

Also, you'll need to add the proto lock file for the build to pass

@glpatcern glpatcern force-pushed the main branch 2 times, most recently from 1daa6aa to 50d4218 Compare September 21, 2021 14:17
@ishank011 ishank011 merged commit 5e29c7c into cs3org:main Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants