-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extensions for the AppProviders to improve the UI #145
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. In general is better to not break backwards compatibility by maintaining the order of the fields in the protobuf definitions. However as this PR introduces a new REQUIRED fields it does not change anything.
@wkloucek please review and approve.
Yeah I thought about that and also about leaving them OPTIONAL (the |
Self-reviewing: This model is still missing the ability to register the mime type attributes (name, ext, icon...) from "outside". A Also, I don't understand why such a large diff in |
192c90b
to
b156daf
Compare
f381ff8
to
f7ab578
Compare
Eventually, this endpoint will be implemented in the Reva HTTP service only as /app/new
Also, you'll need to add the proto lock file for the build to pass |
1daa6aa
to
50d4218
Compare
This PR introduces further extensions for the open-in-app workflow:
AppProvider
s expose acapability
to identify fully fledged editors vs viewersThis allows the UI to e.g. populate a New menu with all types for which an
editor
AppProvider is defined.The extensions constitute breaking changes for the protobuf bindings, and can be merged once cs3org/reva#2067 is ready to be merged.