Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed wait bug when shrinking #584

Merged
merged 4 commits into from
Jan 25, 2021
Merged

Fixed wait bug when shrinking #584

merged 4 commits into from
Jan 25, 2021

Conversation

ggrieco-tob
Copy link
Member

@agroce
Copy link
Contributor

agroce commented Jan 1, 2021

(As noted, this fixes the problem for me, with proper shrinking output)

arcz
arcz previously approved these changes Jan 7, 2021
Copy link
Member

@arcz arcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, just the ci.yml to check

@@ -15,12 +15,12 @@ jobs:
matrix:
os:
- ubuntu-latest
- macos-latest
#- macos-latest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this intended in this PR?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, macos building was failing. I think we should disabled it until we can make it work again (or remove it)

@ggrieco-tob ggrieco-tob merged commit 081b2a1 into master Jan 25, 2021
@ggrieco-tob ggrieco-tob deleted the dev-wait-fix branch January 25, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants