GitHub Actions: improve macOS releases #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4c13548 to
1f0d1c9
Compare
|
where exactly does it put the rpath? does it bundle it as a 3-file group in |
|
It will add |
Currently the CI system fails on macOS with several errors related
to Homebrew. This is a temporal workaround for the issue. See
actions/runner-images#1811
for more details.
Currently the CI system fails due to cache corruption on macOS.
This can be temporarily worked around by using GNU tar instead
of BSD tar. See
actions/cache#403
for more details.
e8da95f to
b51d7df
Compare
Currently, releases for macOS are not very portable. The binaries have hardcoded paths and might not run on other systems. This commit improves the macOS binary releases made via GitHub actions by bundling binary copies of libff, libgmp and libsecp256k1, and by adjusting the rpath and library names to make echidna run on other systems.
5a3b792 to
fc086d4
Compare
|
Why this is still a draft? Are we waiting for the #525 to be merged? |
|
I had built this branch on top of #526 and that's why I had marked it as a draft. I'll open this one in case you want to handle both in one review 🙂 |
incertia
approved these changes
Nov 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, releases for macOS are not very portable. The
binaries have hardcoded paths and might not run on other
systems. This commit improves the macOS binary releases
made via GitHub actions by bundling binary copies of libff,
libgmp and libsecp256k1, and by adjusting the rpath and
library names to make echidna run on other systems.