Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for code size during contract creation (#453, #454) #465

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Add test for code size during contract creation (#453, #454) #465

merged 2 commits into from
Jun 24, 2020

Conversation

elopez
Copy link
Member

@elopez elopez commented Jun 4, 2020

No description provided.

@incertia
Copy link
Contributor

incertia commented Jun 4, 2020

we don't really need to run the entire fuzzing campaign for this contract. all we need is to construct the contract with loadSolTests and call the resulting test with checkETest. feel free to write an auxiliary function that checks all tests and call it checkConstructorConditions or something, or bake the functionality into loadSolidity.

incertia
incertia suggested changes Jun 24, 2020
View reviewed changes
@elopez
Copy link
Member Author

elopez commented Jun 24, 2020

The CI on macOS appears to be broken but it is unrelated to this change, see PR #468 for a possible fix.

@elopez elopez requested a review from incertia June 24, 2020 17:30
@incertia incertia merged commit d8804f3 into crytic:master Jun 24, 2020
@ggrieco-tob ggrieco-tob mentioned this pull request Jun 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@incertia incertia incertia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elopez @incertia