Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix multi_writer specs to close file before reading/deleting it #8674

Merged
merged 1 commit into from
Jan 13, 2020
Merged

Fix multi_writer specs to close file before reading/deleting it #8674

merged 1 commit into from
Jan 13, 2020

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Jan 11, 2020

No description provided.

@oprypin
Copy link
Member Author

oprypin commented Jan 11, 2020

See failures before this: https://github.com/oprypin/crystal/runs/384687812#step:15:66

@oprypin oprypin mentioned this pull request Jan 13, 2020
Merged
@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:files labels Jan 13, 2020
@RX14 RX14 added this to the 0.33.0 milestone Jan 13, 2020
@RX14 RX14 merged commit 26cd639 into crystal-lang:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@straight-shoota straight-shoota straight-shoota approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:files
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.
3 participants
@oprypin @straight-shoota @RX14