Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unforgiving ENV["HOME"] in Path spec #8667

Merged
merged 1 commit into from
Jan 10, 2020
Merged

Fix unforgiving ENV["HOME"] in Path spec #8667

merged 1 commit into from
Jan 10, 2020

Conversation

straight-shoota
Copy link
Member

The environment variable doesn't need to be defined. Accepting nil is completely fine.

@straight-shoota straight-shoota added kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:files labels Jan 9, 2020
@straight-shoota straight-shoota mentioned this pull request Jan 9, 2020
Merged
@RX14 RX14 added this to the 0.33.0 milestone Jan 10, 2020
@RX14 RX14 merged commit 36a4a17 into crystal-lang:master Jan 10, 2020
@straight-shoota straight-shoota deleted the fix/path-spec-home-env branch January 10, 2020 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. kind:specs topic:stdlib:files
Projects
None yet
Milestone
0.33.0
Development

Successfully merging this pull request may close these issues.
2 participants
@straight-shoota @RX14