Implement pow operator for BigDecimal and BigRational #7860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sija
reviewed
Jun 6, 2019
wooster0
reviewed
Jun 10, 2019
RX14
approved these changes
Jun 12, 2019
|
@jwbuiter could you apply the suggestions? You might've fixed them, but they're not in the branch. |
Co-Authored-By: Sijawusz Pur Rahnama <sija@sija.pl> Co-Authored-By: r00ster <r00ster91@protonmail.com>
straight-shoota
approved these changes
Jul 30, 2019
RX14
approved these changes
Jul 30, 2019
|
Thank you @jwbuiter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7680
Since @ananagame closed his PR, I decided to try to implement this for my first contribution.
Instead of an iterative approach, this implementation uses the operators of the underlying BigInt representation to achieve the same results.
I also added tests and tried to format the styles of the tests to match those in the surrounding file.