Allow running compiler_specs with specific flags #7837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use CRYSTAL_SPEC_COMPILER_FLAGS env var to run the compiler specs against a compiler with the specified options
asterite
approved these changes
May 31, 2019
j8r
reviewed
May 31, 2019
Co-Authored-By: Julien Reichardt <mi@jrei.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7805
This PR solves the mentioned issue in the narrowest way: 1.a (only affecting the specs) + 2.a (only allowing compiler flags).
This is use full for testing compiler features behind flags locally and could be used for testing compiler with different configurations in CI.