Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiler: fully track AST nodes name location #7827

Merged
merged 3 commits into from
May 31, 2019
Merged

Compiler: fully track AST nodes name location #7827

merged 3 commits into from
May 31, 2019

Conversation

asterite
Copy link
Member

Fixes #6937

Contains a minor refactor too.

asterite added 3 commits May 28, 2019 12:16
@asterite
Compiler: fully track AST nodes name location
437e348
@asterite
Compiler: remove optional properties from AST nodes constructors
bd8e628 
Stuff like `name_location` or `has_parentheses` is totally optional when
constructing some AST nodes and it makes more sense to set these using
properties instead of specifying optional arguments in the constructor.
It makes the code and the API cleaner.
@asterite
Add test for name location
d212881
@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser labels May 28, 2019
bcardiff
bcardiff approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@bcardiff bcardiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a bit worried if the JSON format of an exception was changing in a way the playground would break. But it seems that that is not changing 🎉

@asterite asterite added this to the 0.29.0 milestone May 31, 2019
@asterite asterite merged commit f0cd45c into crystal-lang:master May 31, 2019
@asterite asterite deleted the bug/name-location branch May 31, 2019 16:00
@Blacksmoke16 Blacksmoke16 mentioned this pull request Jun 1, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sija Sija Sija left review comments

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:parser
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.

Error for undefined method after do, end points to the wrong line
3 participants
@asterite @Sija @bcardiff