Compiler: fix enum overflow on non-default values #7776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of passing `target_type` around we pass it in the constructor, which makes much more sense (I want to interpret values with some target type in mind).
46b721b to
7f08ba6
Compare
bcardiff
approved these changes
May 14, 2019
There was a problem hiding this comment.
I'm not sure if #7271 will be fixable. I guess you are thinking in interpret the constants based on the enum target type, but that will mean that the type a constant expression will depend on the context. It can be a slippery slope from there I think.
Yes, that's what we are doing right now. So if you have I thought to fix #7271 I just had to catch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7268
There's also #7271, which is slightly different, but I'll fix it in a separate PR (it's harder).