Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide hidden matches in non-recursive directories if match_hidden is false. #7774

Merged
merged 2 commits into from
May 13, 2019
Merged

Hide hidden matches in non-recursive directories if match_hidden is false. #7774

merged 2 commits into from
May 13, 2019

Conversation

ayazhafiz
Copy link
Contributor

Fixes #7769

asterite
asterite reviewed May 13, 2019
View reviewed changes
src/dir/glob.cr Outdated Show resolved Hide resolved
@bcardiff bcardiff added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:files labels May 13, 2019
@bcardiff bcardiff added this to the 0.29.0 milestone May 13, 2019
@bcardiff bcardiff merged commit f050127 into crystal-lang:master May 13, 2019
@bcardiff
Copy link
Member

Thanks @ayazhafiz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asterite asterite asterite left review comments

@straight-shoota straight-shoota straight-shoota approved these changes

@bcardiff bcardiff bcardiff approved these changes

Assignees
No one assigned
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:stdlib:files
Projects
None yet
Milestone
0.29.0
Development

Successfully merging this pull request may close these issues.

Dir.glob doesn't hide hidden files in non-recursive directories
4 participants
@ayazhafiz @bcardiff @asterite @straight-shoota