Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: fix error on named args forwarding #7756

Merged
merged 1 commit into from
May 8, 2019
Merged

Compiler: fix error on named args forwarding #7756

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions spec/compiler/semantic/named_args_spec.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,4 +308,14 @@ describe "Semantic: named args" do
),
"no overload matches"
end

it "says correct error when forwarding named args (#7491)" do
assert_error %(
def bar(foo = false)
end

bar(**{foo: true, baz: true})
),
"no argument named 'baz'"
end
end
2 changes: 1 addition & 1 deletion src/compiler/crystal/semantic/call_error.cr
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -580,7 +580,7 @@ class Crystal::Call
named_args.each do |named_arg|
found_index = a_def.args.index { |arg| arg.external_name == named_arg.name }
if found_index
min_size = args.size
min_size = arg_types.size
if found_index < min_size
raise "argument '#{named_arg.name}' already specified"
end
Expand Down