Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiler: fix private def defined inside macro #7733

Merged

Conversation

asterite
Copy link
Member

@asterite asterite commented May 2, 2019

Fixes #7681

Using Location#original_filename will go out of macros to find the filename where the macro was pasted.

@asterite asterite added kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic labels May 2, 2019
@asterite asterite added this to the 0.29.0 milestone May 2, 2019
@asterite asterite merged commit d3aa523 into crystal-lang:master May 2, 2019
@asterite asterite deleted the bug/private-def-inside-macro branch May 2, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug A bug in the code. Does not apply to documentation, specs, etc. topic:compiler:semantic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bugs with protected and private on top-level methods
2 participants